Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: automate docs with eslint-doc-generator #312

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Conversation

bmish
Copy link
Member

@bmish bmish commented Oct 9, 2022

I built this CLI tool eslint-doc-generator for automating the generation of the README rules list and rule doc title/notices for ESLint plugins. It follows common documentation conventions from this and other top ESLint plugins and will help us standardize documentation across ESLint plugins (and generally improve the usability of our custom rules through better documentation and streamline the process of adding new rules).

This is a follow-up to my previous work to manually improve the documentation. eslint-doc-generator is significantly more robust compared to the previous documentation generator script/tests which I have now removed. It has additional functionality (for example, the rules list legend is auto-generated, and the rules list will show additional columns of information when applicable) and 100% test coverage.

Copy link
Member

@MichaelDeBoey MichaelDeBoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this package! 😍

Would be a good one to add to the @eslint-community org if we would do this in all packages I think 🤔

Maybe we should wait for v1 until we do this though?

Copy link
Contributor

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bmish
Copy link
Member Author

bmish commented Oct 10, 2022

Thanks @MichaelDeBoey! Yes I think it's a good goal to move eslint-doc-generator to @eslint-community after it reaches a v1 release. I am currently working to implement all the essential functionality and bug fixes in it so that I can introduce it to ~10 of the top ESLint plugins (and address feedback that I hear during this process).

@bmish bmish merged commit 33fcf78 into main Oct 13, 2022
@bmish bmish deleted the eslint-doc-generator branch October 13, 2022 13:16
@MichaelDeBoey
Copy link
Member

@bmish Not a big deal, but I think we should have waited until eslint-doc-generator reached v1.0.0 tbh

@MichaelDeBoey MichaelDeBoey changed the title Automate docs with eslint-doc-generator docs: automate docs with eslint-doc-generator Oct 13, 2022
@bmish
Copy link
Member Author

bmish commented Oct 13, 2022

That's fair. But yeah, it shouldn't be a big deal, I'll be keeping this updated as I work toward v1. Most of the remaining work is just new features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants