Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve output format of the generated file #6

Merged
merged 1 commit into from
Feb 13, 2021
Merged

Improve output format of the generated file #6

merged 1 commit into from
Feb 13, 2021

Conversation

kimmobrunfeldt
Copy link

@kimmobrunfeldt kimmobrunfeldt commented Feb 13, 2021

By splitting the types into separate lines, editors
have easier time tokenizing and coloring the file. Comment
helps to understand that the file shouldn't be edited
manually.

The new format looks like this:

// This file is auto-generated with postcss-ts-classnames.

export type ClassNames =
  | "\32xl\:col-span-1"
  | "\32xl\:col-span-10"
  | "\32xl\:col-span-11"
  | "\32xl\:col-span-12"
  | "\32xl\:col-span-13"
  | "\32xl\:col-span-14"
  | "\32xl\:col-span-15"
  | "\32xl\:col-span-16";

Fixes #4.

By splitting the types into separate lines, editors
have easier time tokenizing and coloring the file. Comment
helps to understand that the file shouldn't be edited
manually.
@esamattis esamattis merged commit dabbeb5 into esamattis:master Feb 13, 2021
esamattis added a commit that referenced this pull request Feb 13, 2021
@esamattis
Copy link
Owner

Thanks, released in https://github.com/esamattis/postcss-ts-classnames/releases/tag/v0.2.1

@aivenkimmob
Copy link
Contributor

Great, thanks for the quick release! We can get rid of our sed magic :)

@aivenkimmob
Copy link
Contributor

Just noticed there were also tests that I failed to fix in the PR, sorry about that!

@esamattis
Copy link
Owner

esamattis commented Feb 15, 2021

No worries, It seems this project is missing the "on pull request" event from the ci action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Human readable formatting for output
3 participants