scope local install VSN variable #2752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #2751 By default we use the `VSN` variable and let it be overridden. But that variable is not prefixed to anything rebar3 so unrelated variables from random scripts are possible to break by doing this. I believe `VSN` is not documented anywhere, so we should be safe in changing it right away. CC @tsloughter
tsloughter
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2751
By default we use the
VSNvariable and let it be overridden. But that variable is not prefixed to anything rebar3 so unrelated variables from random scripts are possible to break by doing this.I believe
VSNis not documented anywhere, so we should be safe in changing it right away.CC @tsloughter