Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor structure #2720

Merged
merged 2 commits into from
Jul 19, 2022
Merged

Vendor structure #2720

merged 2 commits into from
Jul 19, 2022

Conversation

ferd
Copy link
Collaborator

@ferd ferd commented Jun 19, 2022

This PR is in two parts, and is a proposal to switch up how we do things to facilitate
corporate use cases and the job of linux distribution package maintainers.

Migrate to an umbrella structure

This is a prerequisite for vendoring and demands that we move all source
files around, and update the helper scripts (like bootstrap) to work
with it.

This should have no consequence on rebar3 users aside from needing to
fetch a git_subdir if they need the content for it.

Vendor all dependencies, make bootstrap use them

This makes rebar3 use de-facto offline bootstrap, and avoids hitting the network
to fetch certs anywhere else but when a developer flushes all source files and
re-fetches certifi.

This is done by calling rebar3 as experimental vendor.

@ferd
Copy link
Collaborator Author

ferd commented Jun 19, 2022

Looks like this is blowing up shelltests, mostly around releases. Not too sure about that, will have to dig a bit.

E: was related to missing template data in a partially moved escript config

@ferd
Copy link
Collaborator Author

ferd commented Jun 19, 2022

Oh, fun gotcha: this breaks dialyzer by analyzing deps that were previously not covered...

ferd added 2 commits July 19, 2022 16:15
This is a prerequisite for vendoring and demands that we move all source
files around, and update the helper scripts (like bootstrap) to work
with it.

This should have no consequence on rebar3 users aside from needing to
fetch a git_subdir if they need the content for it.
@ferd ferd merged commit a2ea0c5 into erlang:main Jul 19, 2022
@zuiderkwast zuiderkwast mentioned this pull request Jul 20, 2022
@zuiderkwast
Copy link
Contributor

Will you release this in a minor version soon?

@ferd
Copy link
Collaborator Author

ferd commented Aug 25, 2022

Probably could be doable, we haven't heard any feedback positive or otherwise though, so it's hard to say if it's ready to go.

@zuiderkwast
Copy link
Contributor

We have tested it and it seems to work well. :-) We would prefer a release.

@zuiderkwast
Copy link
Contributor

Still interested in a release. Thanks.

@ferd
Copy link
Collaborator Author

ferd commented Oct 15, 2022

It's finally out, needed CI to work end-to-end to make it all go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants