Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect appdirs when prioritizing module candidates #1418

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

keynslug
Copy link
Contributor

@keynslug keynslug commented Feb 1, 2023

Description

This might be helpful in situations when tooling (e.g. rebar3) makes "shadow copies" in the indexable project directories. This might happen when underlying filesystem lacks sound symlink support, or (in my case) when slightly patched rebar3 is used.

Before this change files having _build/ in filepath were preferred over those having apps/ or src/ for example.

This might be helpful in situations when tooling (e.g. `rebar3`) makes
"shadow copies" in the indexable project directories. Before this
change files having `_build/` in filepath were preferred over those
having `apps/` or `src/` for example.
@plux
Copy link
Contributor

plux commented Dec 21, 2023

Thanks for your contribution @keynslug !

@plux plux merged commit a4047b7 into erlang-ls:main Dec 21, 2023
shuying2244 pushed a commit to shuying2244/erlang_ls that referenced this pull request Dec 30, 2023
This might be helpful in situations when tooling (e.g. `rebar3`) makes
"shadow copies" in the indexable project directories. Before this
change files having `_build/` in filepath were preferred over those
having `apps/` or `src/` for example.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants