Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom definitions for algorithms #527

Merged
merged 2 commits into from
May 24, 2024
Merged

Conversation

tymmale
Copy link
Contributor

@tymmale tymmale commented May 23, 2024

Hi! Great benchmark that you have here.

I noticed that the value of the --definitions argument is only used when listing all available algorithms. Correct me if I'm wrong, but I wanted to pass my own algorithm configurations, which are stored elsewhere, by using --definitions. This doesn't work because the program uses the default path ann-benchmarks/algorithms.

tapas and others added 2 commits May 23, 2024 15:44
@maumueller
Copy link
Collaborator

Thanks @tymmale, this is indeed what --definitions was supposed to do. I'm waiting for the CI and will then merge this.

@maumueller maumueller merged commit fcdf494 into erikbern:main May 24, 2024
35 of 43 checks passed
@tymmale tymmale deleted the dev branch May 24, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants