Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docker tag for Faiss HNSW #496

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Conversation

koron
Copy link
Contributor

@koron koron commented Mar 16, 2024

Fixed an error that occurred when executing in an environment where the docker image for faiss_hnsw existed and the docker image for faiss did not exist.

This will be failed:

# In the environment where ANN Benchmarks is executed for the first time

$ python install.py --algorithm faiss_hnsw

$ python run.py --algorithm 'hnsw(faiss)

Fixed an error that occurred when executing in an environment where the
docker image for faiss_hnsw existed and the docker image for faiss did
not exist.
@maumueller maumueller merged commit 4c8b1c1 into erikbern:main Mar 19, 2024
35 of 41 checks passed
@maumueller
Copy link
Collaborator

You are right, that was indeed a bug. Thanks for the contribution.

(I wonder why we didn't consolidate all FAISS implementations into a single module.)

@koron koron deleted the fix-faiss_hnsw branch March 25, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants