Include string class in primitive.hpp #1831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyCarter
requested changes
Sep 3, 2024
Co-authored-by: Casey Carter <cartec69@gmail.com>
CaseyCarter
approved these changes
Sep 3, 2024
|
The CI is hopelessly out-of-date, I'm going to merge this as-is. Including a standard header may correct a problem, it could never conceivably create a correctness issue. |
the situation is slightly less hopeless now. the macos and windows builds are still failing, but the rest is green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some compilers throw an error when compiling - See : citizenfx/fivem#2763
The easy fix is to add the
#include <string>as some compilers / environnement are not including it, leading to anerror C2039: 'basic_string' is not a member of 'std'