Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding custom spectrum function for random waves #1256

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

adimako
Copy link
Contributor

@adimako adimako commented Mar 28, 2022

Mandatory Checklist

Please ensure that the following criteria are met:

  • Title of pull request describes the changes/features
  • Request at least 2 reviewers
  • If new files are being added, the files are no larger than 100kB. Post the file sizes.
  • Code coverage did not decrease. If this is a bug fix, a test should cover that bug fix. If a new feature is added, a test should be made to cover that feature.
  • New features have appropriate documentation strings (readable by sphinx)
  • Contributor has read and agreed with CONTRIBUTING.md and has added themselves to CONTRIBUTORS.md

As a general rule of thumb, try to follow PEP8 guidelines.

Description

@adimako adimako requested review from cekees and ejtovar March 28, 2022 16:20
@adimako
Copy link
Contributor Author

adimako commented Mar 28, 2022

@cekees @ejtovar this is a development I had made for a project that required the use of a custom spectra for random waves calculations. I was planning to submit at some point, but as I am now leaving, I cannot delay it any more. I will probably write some tests soon not to reduce coverage

Copy link
Member

@cekees cekees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks, good. Thanks @adimako. I will do a release soon after this goes in.

@cekees cekees merged commit 12ae4ee into main Mar 31, 2022
@cekees cekees deleted the adimako/WaveTools/custom_spectrum branch April 15, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants