Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend dockerfile #62

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Backend dockerfile #62

merged 1 commit into from
Feb 14, 2022

Conversation

yamikarajput546
Copy link
Contributor

added Dockerfile and update docker-compose.yml

@aeshub aeshub added the feature New feature or request label Feb 4, 2022
aeshub
aeshub reviewed Feb 4, 2022
View reviewed changes
backend/Dockerfile Outdated Show resolved Hide resolved
aeshub
aeshub reviewed Feb 4, 2022
View reviewed changes
backend/Dockerfile Outdated Show resolved Hide resolved
aeshub
aeshub reviewed Feb 4, 2022
View reviewed changes
backend/Dockerfile Outdated Show resolved Hide resolved
@oysand oysand linked an issue Feb 4, 2022 that may be closed by this pull request
Dockerize backend #55
Closed
@yamikarajput546
Copy link
Contributor Author

yamikarajput546 commented Feb 4, 2022 •
edited
Loading

hey @aestene i've updated the Dockerfile please review :)

@aeshub
Copy link
Contributor

aeshub commented Feb 4, 2022

Hi @yamikarajput546! Thanks for the contribution :)

You were so quick I didn't have time to finish the last review. I had some issue making the application run with Docker as there were some import issues. I've made one comment now which moves to uvicorn but also fixes this.

Finally, I'd like you to squash your commit history into one commit and have that commit message abide by these guidelines. For you a commit message could be Add Dockerfile for backend application

aeshub
aeshub requested changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@aeshub aeshub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comment above.

aeshub
aeshub approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@aeshub aeshub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aeshub
Copy link
Contributor

aeshub commented Feb 14, 2022

Hi @yamikarajput546!

As we are planning to use this functionality soon I took the liberty to finish the remaining points on the review. Thank you for the contribution 🎉

@aeshub aeshub merged commit ffa02c7 into equinor:main Feb 14, 2022
@yamikarajput546
Copy link
Contributor Author

hey @aestene
I really appreciate and thank you also for merging, In the future, you need help to dockerize let me know :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeshub aeshub aeshub approved these changes

Assignees

@yamikarajput546 yamikarajput546

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dockerize backend
2 participants
@yamikarajput546 @aeshub