Use sqlite inmemory database #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Christdej
force-pushed
the
sqlite
branch
6 times, most recently
from
9cf124c
to
52c09e5
Compare
This was
linked to
issues
Jul 8, 2022
Closed
GodVenn
reviewed
Jul 8, 2022
There was a problem hiding this comment.
Looks good, but 4 of the tests fail locally for me, due to the 'concurrency exception'.
EDIT: The tests passed after pulling your branch instead of the PR for some reason.
I also added a commit to move the database config from the Program.cs file to its own service extension to keep the Program.cs file light
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change test / dev database to SQLite.
Add possibility to connect to remote SQL database.
Update tests and usage of database in tests