-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update report on events #224
Conversation
Cancelled | ||
} | ||
|
||
public enum StepType |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not very happy about the "duplication" of StepType
and InspectionType
here but not certain what else to do.
7e32f8c
to
967941f
Compare
There is one issue which I'm uncertain how should be addressed. When starting a mission in ISAR from Flotilla the response from ISAR contains the mission details which Flotilla then writes to the database as a Not entirely certain how this should be resolved. |
967941f
to
355b824
Compare
I think a better way to solve this issue is to move the misssion planner from ISAR to Flotilla so that Flotilla provides the mission to ISAR. That way we can toggle if ISAR should use a local mission planner or be used in combination with Flotilla. We can then write the mission to the database before sending it to ISAR |
355b824
to
e66c489
Compare
I have mentioned this in a new issue #226. It's easier to solve in a different PR and to just include this functionality as it is now. It works somewhat for turtlebot, but there are some unfortunate sideffects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one renaming suggestion
e66c489
to
fe20d39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some naming suggestions for methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fe20d39
to
cb4c973
Compare
cb4c973
to
304ccac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
304ccac
to
5df4613
Compare
Closes #212
Closes #144