Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyvault as config default #210

Merged
merged 3 commits into from
May 20, 2022

Conversation

GodVenn
Copy link
Contributor

@GodVenn GodVenn commented May 18, 2022

This enables us to use the keyvault through the config like we would read any other config variable and simplifies the project structure.

@GodVenn GodVenn added backend Backend related functionality improvement Improvement to existing functionality labels May 18, 2022
@GodVenn GodVenn self-assigned this May 18, 2022
@GodVenn GodVenn force-pushed the AddKeyvaultAsConfigDefault branch from cfb80f3 to 3871d01 Compare May 18, 2022 16:15
Copy link
Contributor

@oysand oysand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only need a default dev key vault set up. Could this be referred to in the readme?

@GodVenn GodVenn force-pushed the AddKeyvaultAsConfigDefault branch from 3871d01 to 3302158 Compare May 20, 2022 08:54
@oysand oysand self-requested a review May 20, 2022 10:31
Copy link
Contributor

@oysand oysand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GodVenn GodVenn force-pushed the AddKeyvaultAsConfigDefault branch from 3302158 to 17cee87 Compare May 20, 2022 12:28
@GodVenn GodVenn merged commit a75178c into equinor:main May 20, 2022
@GodVenn GodVenn deleted the AddKeyvaultAsConfigDefault branch May 20, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related functionality improvement Improvement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants