Continue making readonly more explicit #1716
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andchiind
added
backend
andchiind
force-pushed
the
readonly-true-default
branch
4 times, most recently
from
eec7f00
to
3a9ef0f
Compare
|
🔔 Changes in database folder detected 🔔 |
andchiind
force-pushed
the
readonly-true-default
branch
2 times, most recently
from
99b7d60
to
597b515
Compare
andchiind
force-pushed
the
readonly-true-default
branch
from
597b515
to
ea3c25b
Compare
andchiind
force-pushed
the
readonly-true-default
branch
from
ea3c25b
to
a955315
Compare
|
There is a test failing now which wasn't failing before this PR. In my testing this seems to come down to timing, which in my opinion hints that we may need to rethink that test. The timings have now changed since readonly operations are faster. |
|
See #1730 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.