Verify installation for inspections in the inspection table #1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andchiind
added
bug
andchiind
force-pushed
the
check-installation
branch
from
4946cb7
to
f3aa7e6
Compare
andchiind
force-pushed
the
check-installation
branch
from
f3aa7e6
to
b9d9cbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that we were only checking that deck names were matching, but not that the inspections belonged to the right installation. This solves that issue.
A more permanent solution might be to limit all the mission runs available in the MissionRunsContext to only those of the relevant installation, but this makes it potentially more complicated to switch installations.