Add missing error handling in frontend #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andchiind
added
bug
andchiind
force-pushed
the
frontend-handle-errors
branch
2 times, most recently
from
24c32cd
to
57c33cb
Compare
andchiind
force-pushed
the
frontend-handle-errors
branch
from
57c33cb
to
1064007
Compare
andchiind
force-pushed
the
frontend-handle-errors
branch
from
1064007
to
0a465db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is worth noting that error messages that use the FailedRequestAlertContent component, do not update their translations when the selected language changes. I am looking into this, but it is not a large priority since this is a very niche issue,