Prevent collisions in signalr messages in local development

backend/api/EventHandlers/MqttEventHandler.cs

@@ -372,6 +372,8 @@ private async void OnPressureUpdate(object? sender, MqttReceivedArgs mqttArgs)
             }
             else
             {
+                if (pressureStatus.PressureLevel == robot.PressureLevel) return;
+
                 await robotService.UpdateRobotPressureLevel(robot.Id, pressureStatus.PressureLevel);
                 await timeseriesService.Create(
                     new RobotPressureTimeseries

backend/api/Program.cs

@@ -19,6 +19,8 @@
 
 Console.WriteLine($"\nENVIRONMENT IS SET TO '{builder.Environment.EnvironmentName}'\n");
 
+builder.Configuration.AddEnvironmentVariables();
+
 builder.AddAzureEnvironmentVariables();
 
 if (builder.Configuration.GetSection("KeyVault").GetValue<bool>("UseKeyVault"))

backend/api/Services/SignalRService.cs

@@ -11,7 +11,7 @@ public interface ISignalRService
         public Task SendMessageAsync(string label, Installation? installation, string message);
     }
 
-    public class SignalRService(IHubContext<SignalRHub> signalRHub) : ISignalRService
+    public class SignalRService(IHubContext<SignalRHub> signalRHub, IConfiguration configuration) : ISignalRService
     {
         private readonly JsonSerializerOptions _serializerOptions = new() { PropertyNamingPolicy = JsonNamingPolicy.CamelCase };
 
@@ -23,10 +23,24 @@ public async Task SendMessageAsync<T>(string label, Installation? installation,
 
         public async Task SendMessageAsync(string label, Installation? installation, string message)
         {
-            if (installation != null)
-                await signalRHub.Clients.Group(installation.InstallationCode.ToUpper(CultureInfo.CurrentCulture)).SendAsync(label, "all", message);
+            if (Environment.GetEnvironmentVariable("ASPNETCORE_ENVIRONMENT") == "Local")
+            {
+                string? localDevUser = configuration.GetSection("Local")["DevUserId"];
+                if (localDevUser is null || localDevUser.Equals("", StringComparison.Ordinal)) return;
+
+                if (installation != null)
+                    await signalRHub.Clients.Group(localDevUser + installation.InstallationCode.ToUpper(CultureInfo.CurrentCulture)).SendAsync(label, "all", message);
+                else
+                    await signalRHub.Clients.Group(localDevUser).SendAsync(label, "all", message);
+            }
             else
-                await signalRHub.Clients.All.SendAsync(label, "all", message);
+            {
+                if (installation != null)
+                    await signalRHub.Clients.Group(installation.InstallationCode.ToUpper(CultureInfo.CurrentCulture)).SendAsync(label, "all", message);
+                else
+                    await signalRHub.Clients.All.SendAsync(label, "all", message);
+            }
+
 
             await Task.CompletedTask;
         }

backend/api/SignalR/SignalRHub.cs

@@ -7,7 +7,7 @@ public interface ISignalRClient
     {
     }
 
-    public class SignalRHub(IAccessRoleService accessRoleService) : Hub<ISignalRClient>
+    public class SignalRHub(IAccessRoleService accessRoleService, IConfiguration configuration) : Hub<ISignalRClient>
     {
         /// <summary>
         /// Called when a new connection is made.
@@ -20,9 +20,21 @@ public override async Task OnConnectedAsync()
                     .Where((c) => c.Type.EndsWith("/role", StringComparison.CurrentCulture)).Select((c) => c.Value).ToList();
 
                 var installationCodes = await accessRoleService.GetAllowedInstallationCodes(roles);
-                foreach (string installationCode in installationCodes)
+
+                if (Environment.GetEnvironmentVariable("ASPNETCORE_ENVIRONMENT") == "Local")
+                {
+                    string? localDevUser = configuration.GetSection("Local")["DevUserId"];
+                    if (localDevUser is null || localDevUser.Equals("", StringComparison.Ordinal))
+                        throw new HubException("Running in development mode, but missing Local__DevUserId value in environment");
+
+                    await Groups.AddToGroupAsync(Context.ConnectionId, localDevUser); // This is used instead of Users.All
+                    foreach (string installationCode in installationCodes)
+                        await Groups.AddToGroupAsync(Context.ConnectionId, localDevUser + installationCode.ToUpperInvariant());
+                }
+                else
                 {
-                    await Groups.AddToGroupAsync(Context.ConnectionId, installationCode.ToUpperInvariant());
+                    foreach (string installationCode in installationCodes)
+                        await Groups.AddToGroupAsync(Context.ConnectionId, installationCode.ToUpperInvariant());
                 }
             }
 

backend/api/appsettings.Local.json

@@ -47,5 +47,8 @@
   },
   "Database": {
     "UseInMemoryDatabase": true
+  },
+  "Local": {
+    "DevUserId": ""
   }
 }

setup.sh

@@ -64,6 +64,26 @@ if [ "$backend_abort" != "true" ]; then
     dotnet user-secrets set "AzureAd:ClientSecret" $az_client_secret --project backend/api > /dev/null
     echo -e "Added client secret to ASP.NET secret manager"
 
+    echo -e "A username is needed for local development with SignalR"
+    echo -en "Input a username for yourself (this only needs to be unique within your development environment):\n" 
+
+    while [ true ]
+    do
+        read -s local_dev_username
+
+        if [ -z "$local_dev_username" ]; then
+            echo "The local dev username cannot be empty"
+            echo "Try again:"
+        else
+            break
+        fi
+    done
+
+
+    echo "Local__DevUserId='$local_dev_username'" >> $flotilla_dir/.env
+    dotnet user-secrets set "Local:DevUserId" $az_client_secret --project backend/api > /dev/null
+    echo -e "Added local development username to .env file"
+
     echo -e "Backup setup - Done!"
     echo -e "-----------------------------\n"
 fi