Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make add mission button and queue independent #1198

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Make add mission button and queue independent #1198

merged 2 commits into from
Dec 13, 2023

Conversation

mrica-equinor
Copy link
Contributor

Closes #1173

@mrica-equinor mrica-equinor self-assigned this Nov 17, 2023
@mrica-equinor mrica-equinor added improvement Improvement to existing functionality frontend Frontend related functionality labels Nov 17, 2023
@Eddasol
Copy link
Contributor

Eddasol commented Nov 24, 2023

Suggest removing the buttons from mission queue view and changing the "add mission"-button text to something like "Add predefined echo mission"

andchiind
andchiind approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@andchiind andchiind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrica-equinor mrica-equinor force-pushed the move-add-mission-button branch 6 times, most recently from 74e66e1 to 3738a02 Compare December 12, 2023 14:49
eivindsjovold
eivindsjovold approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@eivindsjovold eivindsjovold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test locally™️ but LGTM

@mrica-equinor mrica-equinor merged commit 5261e61 into equinor:main Dec 13, 2023
10 checks passed
@mrica-equinor mrica-equinor deleted the move-add-mission-button branch May 13, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eddasol Eddasol Eddasol left review comments

@andchiind andchiind andchiind approved these changes

@eivindsjovold eivindsjovold eivindsjovold approved these changes

Assignees

@mrica-equinor mrica-equinor

Labels
frontend Frontend related functionality improvement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move "Add mission"-button
4 participants
@mrica-equinor @Eddasol @andchiind @eivindsjovold