feat: Adding Oracle Terraform Provider to Fabric Examples #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
srushti-patl
commented
Apr 17, 2024
srushti-patl
commented
- Added Oracle Terraform Provider in following examples:
- FCR 2 Oracle
- Port 2 Oracle
- NIMF 2 Oracle
- Updated terratests-metal-nimf-suite.yaml workflow by adding ORACLE_SERVICE_KEYS
- Updated outputs.tf files for azure connections
…ation' into CXF-91727-Oracle-Provider-Integration
…ation' into CXF-91727-Oracle-Provider-Integration
thogarty
requested changes
May 2, 2024
| @@ -5,5 +5,9 @@ terraform { | |||
| source = "equinix/equinix" | |||
| version = ">= 1.20.0" | |||
There was a problem hiding this comment.
You need to change the version for all examples to use the version that includes your WaitForDeprovision changes. The versions before that won't work for these examples.
| @@ -75,11 +75,6 @@ variable "zside_ap_type" { | |||
| description = "Access point type - COLO, VD, VG, SP, IGW, SUBNET, GW" | |||
There was a problem hiding this comment.
This file shoudl be renamed to variables.tf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.