feat: Add FCR 2 Metal Redundant Connection Example #108
Conversation
d-bhola
commented
Aug 1, 2024
d-bhola
commented
- The PR contains a new example for FCR 2 Metal Redundant Connection.
- This includes one FCR, one Metal Network and two connections - Primary and Secondary (Redundant)
- The changes are tested in prod and redundant connection is successfully created.
| direct_rp_name = var.secondary_direct_rp_name | ||
| direct_equinix_ipv4_ip = var.secondary_direct_equinix_ipv4_ip | ||
| } | ||
| resource "time_sleep" "wait_dl_connection" { |
There was a problem hiding this comment.
Remove time_sleep and metal connection data source, It's only required when we are adding example to Sanity suite.
| @@ -0,0 +1,27 @@ | |||
| equinix_client_id = "<MyEquinixClientId>" | |||
There was a problem hiding this comment.
format terraform.tfvars.example file
| @@ -0,0 +1,80 @@ | |||
| provider "equinix" { | |||
There was a problem hiding this comment.
Add extra spaces between all code blocks
|
Addressed all PR comments 👍 |
|
|
||
| See example usage below for details on how to use this example. | ||
|
|
||
| <!-- Begin Example Usage (Do not edit contents) --> |
There was a problem hiding this comment.
These don't belong. We're not leveraging them anymore. Please remove.
There was a problem hiding this comment.
Clarity on comment: we don't need these boundary declarations anymore <!-- Begin Example Usage (Do not edit contents) -->. They were for the previous shell script methods but now that we just use terraform-docs then we won't have any need for these. Hope that clears it up.
There was a problem hiding this comment.
Addressed with commit
| primary_direct_rp_name = "pri_direct_rp" | ||
| secondary_direct_rp_name = "sec_direct_rp" | ||
| primary_direct_equinix_ipv4_ip = "190.1.1.25/30" | ||
| secondary_direct_equinix_ipv4_ip = "190.1.1.9/30" |
There was a problem hiding this comment.
I would reorder the example variables to match the ordering present in variables.tf files.
There was a problem hiding this comment.
Addressed with commit
