Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Updated metal-go client for sub-commands Virtual Network #315

Merged
merged 1 commit into from
Oct 9, 2023
Merged

fix: Updated metal-go client for sub-commands Virtual Network #315

merged 1 commit into from
Oct 9, 2023

Conversation

codinja1188
Copy link
Contributor

No description provided.

@codinja1188 codinja1188 temporarily deployed to external July 27, 2023 13:03 — with GitHub Actions Inactive
@codinja1188 codinja1188 temporarily deployed to external August 2, 2023 16:59 — with GitHub Actions Inactive
@codinja1188 codinja1188 temporarily deployed to external August 3, 2023 16:11 — with GitHub Actions Inactive
ctreatma
ctreatma reviewed Aug 3, 2023
View reviewed changes
internal/vlan/create.go Outdated Show resolved Hide resolved
internal/vlan/retrieve.go Outdated Show resolved Hide resolved
internal/vlan/retrieve.go Outdated Show resolved Hide resolved
ctreatma
ctreatma requested changes Aug 3, 2023
View reviewed changes
test/e2e/vlan_test.go Outdated Show resolved Hide resolved
test/e2e/vlan_test.go Outdated Show resolved Hide resolved
@codinja1188 codinja1188 temporarily deployed to external August 3, 2023 16:45 — with GitHub Actions Inactive
ctreatma
ctreatma previously requested changes Aug 3, 2023
View reviewed changes
internal/vlan/retrieve.go Outdated Show resolved Hide resolved
test/e2e/vlan_test.go Outdated Show resolved Hide resolved
@codinja1188 codinja1188 mentioned this pull request Aug 16, 2023
Closed
15 tasks
@codinja1188 codinja1188 temporarily deployed to external September 4, 2023 16:55 — with GitHub Actions Inactive
@codinja1188 codinja1188 temporarily deployed to external September 11, 2023 14:19 — with GitHub Actions Inactive
@codinja1188 codinja1188 changed the title Updated metal-go client for sub-commands Virtual Network fix: Updated metal-go client for sub-commands Virtual Network Sep 11, 2023
@codinja1188 codinja1188 temporarily deployed to external October 2, 2023 10:31 — with GitHub Actions Inactive
@codinja1188 codinja1188 temporarily deployed to external October 3, 2023 14:42 — with GitHub Actions Inactive
@codinja1188 codinja1188 temporarily deployed to external October 8, 2023 06:21 — with GitHub Actions Inactive
@cprivitere cprivitere temporarily deployed to external October 9, 2023 17:46 — with GitHub Actions Inactive
@cprivitere cprivitere temporarily deployed to external October 9, 2023 20:07 — with GitHub Actions Inactive
cprivitere
cprivitere approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@cprivitere cprivitere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked!

@cprivitere
Copy link
Contributor

Overriding test results cause it's due to being out of m3.smalls in Dallas.

@cprivitere cprivitere merged commit 5746b18 into equinix:main Oct 9, 2023
7 of 8 checks passed
@ctreatma ctreatma mentioned this pull request Apr 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@displague displague displague left review comments

@cprivitere cprivitere cprivitere approved these changes

@ctreatma ctreatma ctreatma left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codinja1188 @cprivitere @displague @ctreatma