Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle cover art for multi-disc albums stored in seperate folders #6

Closed
arthurl opened this issue Oct 25, 2019 · 1 comment
Closed
Milestone

Comments

@arthurl
Copy link

arthurl commented Oct 25, 2019

Issue description

I typically store multi-disc albums using the following directory structure:

$albumname/CD01/01 $disc01-track01_name
$albumname/CD01/02 $disc01-track02_name
$albumname/CD01/...
$albumname/CD02/01 $disc02-track01_name
$albumname/CD02/...
$albumname/cover.jpg

In this case, cover.jpg is not picked up as the album cover, even though LMS correctly recognises all the directories as a single album.

Q: How are covers currently handled?

I’ve tried looking at the code, but I’m a bit confused. When is cover art retrieved using Grabber::getFromRelease vs Grabber::getFromTrack (in src/cover/CoverArtGrabber.cpp)? Isn’t cover art displayed only for entire albums, and not for the individual track?

@epoupon
Copy link
Owner

epoupon commented Oct 25, 2019

Actually, LMS tries to get the release cover from the first scanned track of this release.
If the cover is embedded in the audio file, that's done.
If it is not embedded in the audio file, it will try to find a cover file in the directory where the file is stored.
Here I would say it looks in the directory 'CD01'.
Not sure if looking for a cover file in the parent directory makes sense, but I guess we could do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants