Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

persist data for inbox filtering right away #788

Merged
merged 6 commits into from
Sep 20, 2024
Merged

persist data for inbox filtering right away #788

merged 6 commits into from
Sep 20, 2024

Conversation

saulmc
Copy link
Member

@saulmc saulmc commented Sep 20, 2024 •
edited
Loading

Closes #785 - Group requests move between inbox views

  • Persist groupCreator and groupAddedBy so that group requests promoted to main inbox stay there
  • Compute spam scores for groups so that group requests stay in the proper folder
  • Exclude group conversations from likelyNotSpam by default
  • Always show the segmented controller, so that spam is not mistaken as requests

@saulmc saulmc requested a review from a team as a code owner September 20, 2024 07:58
@saulmc saulmc marked this pull request as draft September 20, 2024 07:58
@saulmc saulmc marked this pull request as ready for review September 20, 2024 08:17
nmalzieu
nmalzieu previously requested changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@nmalzieu nmalzieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments about network / async calls and potential loop, apart from that looks good!

data/helpers/conversations/upsertConversations.ts Show resolved Hide resolved
data/helpers/conversations/upsertConversations.ts Outdated Show resolved Hide resolved
data/helpers/conversations/upsertConversations.ts Show resolved Hide resolved
utils/xmtpRN/conversations.ts Outdated Show resolved Hide resolved
cameronvoell
cameronvoell approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this issue is now looking good for me, nice fix!

#785

@saulmc saulmc merged commit 44b2561 into main Sep 20, 2024
4 checks passed
@saulmc saulmc deleted the saulmc/persist-group-creator-addedby branch September 20, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameronvoell cameronvoell cameronvoell approved these changes

@nmalzieu nmalzieu nmalzieu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Group requests move between inbox views
3 participants
@saulmc @cameronvoell @nmalzieu