Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename RequestInfo to StreamInfo #4503

Merged
merged 7 commits into from
Oct 5, 2018
Merged

Rename RequestInfo to StreamInfo #4503

merged 7 commits into from
Oct 5, 2018

Conversation

venilnoronha
Copy link
Member

@venilnoronha venilnoronha commented Sep 22, 2018 •
edited
Loading

Description:
This PR renames RequestInfo to StreamInfo as discussed in this comment thread and #4500.

Signed-off-by: Venil Noronha veniln@vmware.com

Risk Level: Low
Testing: Existing tests suffice
Docs Changes: N/A
Release Notes: Added a line about the change
Fixes #4500.

/cc @ggreenway

mattklein123
mattklein123 previously approved these changes Sep 24, 2018
View reviewed changes
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I like this name. @envoyproxy/maintainers @rshriram everyone cool with this name?

dnoe
dnoe previously approved these changes Sep 24, 2018
View reviewed changes
junr03
junr03 previously approved these changes Sep 24, 2018
View reviewed changes
lizan
lizan suggested changes Sep 24, 2018
View reviewed changes
Copy link
Member

@lizan lizan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with the name, but shall we wait merging this until 1.8.0 is cut? For out-of-tree extensions this will be non-trivial update.

@venilnoronha can you add a line into release note?

@mattklein123
Copy link
Member

OK sounds good to hold for 1.8.0. I think we should try to get 1.8.0 out by the end of next week.

@stale
Copy link

stale bot commented Oct 1, 2018

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Oct 1, 2018
@venilnoronha
Copy link
Member Author

not stale.

@stale stale bot removed the stale stalebot believes this issue/PR has not been touched recently label Oct 1, 2018
@lizan lizan added the no stalebot Disables stalebot from closing an issue label Oct 1, 2018
@venilnoronha venilnoronha force-pushed the rename-request-info branch 3 times, most recently from 8504b05 to 2552adb Compare October 4, 2018 23:17
@mattklein123
Copy link
Member

@venilnoronha we can take this now. Can you merge master? Thank you!

@venilnoronha
Copy link
Member Author

Yup, just doing that.

@venilnoronha
Rename RequestInfo to StreamInfo
3ef9ab2 
Signed-off-by: Venil Noronha <veniln@vmware.com>
@venilnoronha
Add release note for the change
b5b0676 
Signed-off-by: Venil Noronha <veniln@vmware.com>
@venilnoronha
Move release note under 1.9.0
bad9e9b 
Signed-off-by: Venil Noronha <veniln@vmware.com>
@venilnoronha
Fix conflict in version_history.rst
3d7f618 
Signed-off-by: Venil Noronha <veniln@vmware.com>
@venilnoronha
Fix newer RequestInfo occurrences
019aa20 
Signed-off-by: Venil Noronha <veniln@vmware.com>
@venilnoronha
Fix merge conflict in version_history.rst
6acb6f0 
Signed-off-by: Venil Noronha <veniln@vmware.com>
@venilnoronha
Fix misspelling
b16d39c 
Signed-off-by: Venil Noronha <veniln@vmware.com>
mattklein123
mattklein123 approved these changes Oct 4, 2018
View reviewed changes
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mattklein123 mattklein123 removed the no stalebot Disables stalebot from closing an issue label Oct 4, 2018
@mattklein123 mattklein123 removed the no stalebot Disables stalebot from closing an issue label Oct 4, 2018
@mattklein123 mattklein123 merged commit ce634f4 into envoyproxy:master Oct 5, 2018
@venilnoronha venilnoronha mentioned this pull request Oct 5, 2018
Merged
junr03 pushed a commit that referenced this pull request Oct 5, 2018
@venilnoronha @junr03
Update StreamInfo related documentation (#4609)
8389aa2 
Description:
This PR updates the documentation related to the recent rename of RequestInfo to StreamInfo. Missed these changes in #4503. Also, see #4500 for further info.

Risk Level: Low
Testing: N/A
Docs Changes: Multiple
Release Notes: N/A

Signed-off-by: Venil Noronha <veniln@vmware.com>
aa-stripe pushed a commit to aa-stripe/envoy that referenced this pull request Oct 11, 2018
@venilnoronha @aa-stripe
Rename RequestInfo to StreamInfo (envoyproxy#4503)
9cc69e2 
Signed-off-by: Venil Noronha <veniln@vmware.com>
Signed-off-by: Aaltan Ahmad <aa@stripe.com>
aa-stripe pushed a commit to aa-stripe/envoy that referenced this pull request Oct 11, 2018
@venilnoronha @aa-stripe
Update StreamInfo related documentation (envoyproxy#4609)
b2b3e36 
Description:
This PR updates the documentation related to the recent rename of RequestInfo to StreamInfo. Missed these changes in envoyproxy#4503. Also, see envoyproxy#4500 for further info.

Risk Level: Low
Testing: N/A
Docs Changes: Multiple
Release Notes: N/A

Signed-off-by: Venil Noronha <veniln@vmware.com>
Signed-off-by: Aaltan Ahmad <aa@stripe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramaraochavali ramaraochavali ramaraochavali left review comments

@lizan lizan lizan approved these changes

@mattklein123 mattklein123 mattklein123 approved these changes

@dnoe dnoe dnoe left review comments

@junr03 junr03 junr03 left review comments

@zuercher zuercher Awaiting requested review from zuercher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@venilnoronha @mattklein123 @lizan @dnoe @junr03 @ramaraochavali