stats: fix merge during shutdown #3289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rama <rama.rao@salesforce.com>
mattklein123
reviewed
May 4, 2018
| @@ -109,6 +109,9 @@ void ThreadLocalStoreImpl::mergeHistograms(PostMergeCb merge_complete_cb) { | |||
| } | |||
| }, | |||
| [this, merge_complete_cb]() -> void { mergeInternal(merge_complete_cb); }); | |||
| } else { | |||
| // If server is shutting down, just call the callback to allow flush to continue. | |||
| merge_complete_cb(); | |||
There was a problem hiding this comment.
Please add a test for this case.
Signed-off-by: Rama <rama.rao@salesforce.com>
mattklein123
changed the title
jmarantz
approved these changes
May 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rama rama.rao@salesforce.com
Description:
Risk Level: Low
Testing: Automated
Docs Changes: NA
Release Notes: NA
Fixes #3287