Use flags for access log when injecting failures #287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rshriram
changed the title
|
it's good to rebase with the latest master (need to add DI to ResponseFlags, etc) |
|
Opening a new PR as this branch has diverged a bit with the code. |
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
* Support variable binding * fix format
PiotrSikora
added a commit
to PiotrSikora/envoy
that referenced
this pull request
Nov 5, 2019
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
howardjohn
referenced
this pull request
in istio/envoy
Nov 5, 2019
lizan
pushed a commit
to lizan/envoy
that referenced
this pull request
Nov 25, 2019
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
gargnupur
pushed a commit
to gargnupur/envoy
that referenced
this pull request
Dec 10, 2020
…1-envoy-sync Sync with Envoy 1.16.1 to bring in two security fixes.
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
To mirror: envoyproxy/envoy-mobile#277 Signed-off-by: Alan Chiu <achiu@lyft.com> For an explanation of how to fill out the fields, please see the relevant section in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/master/PULL_REQUESTS.md) Description: expose URL components instead of URL type Risk Level: low Testing: unit Docs Changes: n/a Release Notes: n/a [Optional Fixes #Issue] [Optional Deprecated:] Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
To mirror: envoyproxy/envoy-mobile#277 Signed-off-by: Alan Chiu <achiu@lyft.com> For an explanation of how to fill out the fields, please see the relevant section in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/master/PULL_REQUESTS.md) Description: expose URL components instead of URL type Risk Level: low Testing: unit Docs Changes: n/a Release Notes: n/a [Optional Fixes #Issue] [Optional Deprecated:] Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should be merged with #274 and not with master.
Set response code for delay injection
Add unit tests to check both flags accordingly