Fixing watermark preconditions #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattklein123
previously approved these changes
Aug 22, 2017
There was a problem hiding this comment.
@alyssawilk per off-line convo, do you mind opening an issue on what kinds of tests we would need to add so that we could have caught this with our own integration tests?
htuch
reviewed
Aug 22, 2017
| // When the server stream is created it should check the status of the | ||
| // underlying connection. Pretend it is overrun. | ||
| EXPECT_CALL(server_connection_, aboveHighWatermark()).WillOnce(Return(true)); | ||
| EXPECT_CALL(server_stream_callbacks2, onAboveWriteBufferHighWatermark()).Times(1); |
htuch
previously approved these changes
Aug 22, 2017
mattklein123
approved these changes
Aug 22, 2017
|
#1518
Basically a brain dump of what I miss from GFE tests (excluding things
already in issue 1162)
…On Tue, Aug 22, 2017 at 12:05 PM, Matt Klein ***@***.***> wrote:
***@***.**** approved this pull request.
@alyssawilk <https://github.com/alyssawilk> per off-line convo, do you
mind opening an issue on what kinds of tests we would need to add so that
we could have caught this with our own integration tests?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1509 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ARYFvcCivReKIZz1rwm2a5uBiTbnpgsCks5savxggaJpZM4O-zav>
.
|
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
* envoy: update and modify new include paths Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
* envoy: update and modify new include paths Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in my implementation of #150 where we were passing connection-level flow control blockage to new client side streams but not new server side streams.
@htuch @PiotrSikora this should unblock our internal merge.