Skip to content

Commit

Permalink
perf: update test binary size target (#212)
Browse files Browse the repository at this point in the history
Signed-off-by: Jose Nino jnino@lyft.com

Description: after #173 landed this target broke due to the breaking API change. This target will be added to CI once #181 closes, so breakages like this will not go undected.
Risk Level: low - updating API, deleting old build rules.

Signed-off-by: JP Simard <jp@jpsim.com>
  • Loading branch information
junr03 authored and jpsim committed Nov 28, 2022
1 parent dc1b6d6 commit 7856770
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 10 deletions.
8 changes: 0 additions & 8 deletions mobile/library/common/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,3 @@ cc_library(
],
deps = [":envoy_main_interface_lib"],
)

envoy_cc_binary(
name = "test_binary_size",
srcs = ["test_binary_size.cc"],
repository = "@envoy",
stamped = True,
deps = ["envoy_main_interface_lib"],
)
4 changes: 2 additions & 2 deletions mobile/test/performance/test_binary_size.cc
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#include "main_interface.h"
#include "library/common/main_interface.h"

// NOLINT(namespace-envoy)

// This binary is used to perform stripped down binary size investigations of the Envoy codebase.
// Please refer to the development docs for more information:
// https://envoy-mobile.github.io/docs/envoy-mobile/latest/development/performance/binary_size.html
int main() { return run_envoy(nullptr); }
int main() { return run_envoy(nullptr, nullptr); }

0 comments on commit 7856770

Please sign in to comment.