Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pending tests for hash consistency. #9588

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Remove pending tests for hash consistency. #9588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ad9faf
remove pending tests
GregoryTravis Apr 1, 2024
6b257aa
Merge branch 'develop' into wip/gmt/9296-remove-pending-tests
GregoryTravis Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions test/Base_Tests/src/Data/Decimal_Spec.enso
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ add_specs suite_builder =
(Comparable.hash_builtin x0) . should_equal (Comparable.hash_builtin x1)

group_builder.specify "should compare correctly to Integer and Float" <|
ok_values = []
values = []
+ [[0.1, 0.1]]
+ [["0.1", 0.1]]
+ [["0", 0]]
Expand Down Expand Up @@ -297,16 +297,6 @@ add_specs suite_builder =
+ [[Float.max_value-1.0, Float.max_value-1.0]]
+ [[-Float.max_value+1.0, -Float.max_value+1.0]]

problematic_values = []
+ [[9223372036854776000.0, 9223372036854776000.0]]
+ [[-9223372036854776000.0, -9223372036854776000.0]]
+ [["9223372036854776000.0", 9223372036854776000.0]]
+ [["-9223372036854776000.0", -9223372036854776000.0]]

# TODO: Include problematic values pending https://github.com/enso-org/enso/issues/9296.
values = ok_values # + problematic_values
_ = [problematic_values]

values.map pr->
v = pr.at 0
d = Decimal.new v
Expand Down
10 changes: 0 additions & 10 deletions test/Base_Tests/src/Data/Numbers_Spec.enso
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,16 +611,6 @@ add_specs suite_builder =
3.truncate . should_equal 3
-3.truncate . should_equal -3

suite_builder.group "Hashing" group_builder->
# TODO: Pending https://github.com/enso-org/enso/issues/9296
group_builder.specify "Hash consistency for values near Double.MIN/MAX_VALUE" pending="hash consistency" <|
ok_values = [9223372036854775000, -9223372036854775000]
bad_values = [9223372036854776000, -9223372036854776000]
values = ok_values + bad_values
values.map i->
f = i.to_float
(Comparable.hash_builtin f) . should_equal (Comparable.hash_builtin i)

suite_builder.group "Number Conversions" group_builder->
group_builder.specify "Complex plus Integer" <|
v1 = (Complex.new 1 2) + (Complex.new 3)
Expand Down
Loading