Decimal remainder, pow, div #9566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregoryTravis
requested review from
jdunkerley,
radeusgd and
AdRiley
as code owners
radeusgd
reviewed
Mar 28, 2024
Comment on lines
529
to
530
| Remainder in Enso will undergo automatic conversions such that you need | ||
| not convert other numeric types to `Decimal` manually. |
There was a problem hiding this comment.
This sounds to me like the result of the operation will undergo conversions, which as far as I understand is not the case and you mean the arguments, right?
Maybe we can rephrase it to make it clearer?
Suggested change
| Remainder in Enso will undergo automatic conversions such that you need | |
| not convert other numeric types to `Decimal` manually. | |
| Arguments of the `remainder` operation will undergo automatic conversions such that you need | |
| not convert other numeric types to `Decimal` manually. |
maybe something like that?
- I don't think you need to say
in Ensothere - this is an Enso library so that is rather assumed, - IMO it's good to point you mean arguments
radeusgd
reviewed
Mar 28, 2024
Comment on lines
498
to
507
| + [[5, 3, 2], [5.0, 3.0, 2.0], [3.5, 2, 1.5], [10.5, 1.0, 0.5], [3, 1, 0], [3.0, 1.0, 0]] | ||
| + [[-5, 3, -2], [-5.0, 3.0, -2.0], [-3.5, 2, -1.5], [-10.5, 1.0, -0.5], [-3, 1, 0], [-3.0, 1.0, 0]] | ||
| + [["9223372036854775807", 10, 7], ["9223372036854775808", 10, 8], ["922337203685477580000000000008", 10, 8]] | ||
| + [["-9223372036854775808", 10, -8], ["-9223372036854775809", 10, -9], ["-922337203685477580000000000008", 10, -8]] | ||
| cases.map c-> | ||
| base = c.at 0 | ||
| modulus = c.at 1 | ||
| residue = c.at 2 | ||
| (Decimal.new base % modulus) . should_equal residue | ||
| (Decimal.new base % Decimal.new modulus) . should_equal residue |
There was a problem hiding this comment.
I'd probably add a test case for something like 2.7 % 0.5. Should it work and return 0.2 or are non-integer arguments not allowed? Either way it would be good to have a test.
radeusgd
reviewed
Mar 28, 2024
radeusgd
approved these changes
Mar 28, 2024
AdRiley
approved these changes
Mar 28, 2024
GregoryTravis
added
CI: Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.