Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new aliases for take #9500

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Add new aliases for take #9500

merged 1 commit into from
Mar 20, 2024

Conversation

AdRiley
Copy link
Member

@AdRiley AdRiley commented Mar 20, 2024

Pull Request Description

Add some more aliases for take

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@AdRiley AdRiley added the CI: No changelog needed Do not require a changelog entry for this PR. label Mar 20, 2024
radeusgd
radeusgd approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does foot come from in here?

@AdRiley AdRiley merged commit 933608e into develop Mar 20, 2024
39 of 41 checks passed
@AdRiley AdRiley deleted the wip/adr/add-new-aliases branch March 20, 2024 16:15
@AdRiley
Copy link
Member Author

AdRiley commented Mar 20, 2024

Where does foot come from in here?

James :) I think it is the opposite of head

@radeusgd
Copy link
Member

Where does foot come from in here?

James :) I think it is the opposite of head

That's tail usually, no?

I have never ever heard of foot being used in such a context.

@somebody1234
Copy link
Contributor

or last perhaps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radeusgd radeusgd radeusgd approved these changes

@jdunkerley jdunkerley jdunkerley approved these changes

@GregoryTravis GregoryTravis Awaiting requested review from GregoryTravis GregoryTravis is a code owner

Assignees
No one assigned
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AdRiley @radeusgd @somebody1234 @jdunkerley