Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runtime checks of signatures with polyglot java classes #8016

Merged
merged 9 commits into from
Oct 11, 2023
Merged

Runtime checks of signatures with polyglot java classes #8016

merged 9 commits into from
Oct 11, 2023

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Oct 10, 2023 •
edited
Loading

Pull Request Description

Fixes #7858 by creating ReadArgumentCheckNode.MetaCheckNode instances and using InteropLibrary.getMetaObject.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Scala,
    Java,
  • All code has been tested:
    • Unit tests have been written where possible.

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Oct 10, 2023
@JaroslavTulach JaroslavTulach self-assigned this Oct 10, 2023
@JaroslavTulach JaroslavTulach force-pushed the wip/jtulach/JavaClassesRuntimeChecks_7858 branch from 5188da9 to 611597e Compare October 11, 2023 07:27
@JaroslavTulach JaroslavTulach force-pushed the wip/jtulach/JavaClassesRuntimeChecks_7858 branch from 611597e to b6b4d6d Compare October 11, 2023 07:28
radeusgd
radeusgd approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! ❤️

@JaroslavTulach JaroslavTulach merged commit 7ae0971 into develop Oct 11, 2023
34 checks passed
@JaroslavTulach JaroslavTulach deleted the wip/jtulach/JavaClassesRuntimeChecks_7858 branch October 11, 2023 13:05
@enso-bot enso-bot bot mentioned this pull request Oct 12, 2023
Closed
@JaroslavTulach JaroslavTulach mentioned this pull request Jan 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radeusgd radeusgd radeusgd approved these changes

@Akirathan Akirathan Akirathan approved these changes

@jdunkerley jdunkerley Awaiting requested review from jdunkerley jdunkerley is a code owner

@GregoryTravis GregoryTravis Awaiting requested review from GregoryTravis GregoryTravis is a code owner

@4e6 4e6 Awaiting requested review from 4e6 4e6 is a code owner

@hubertp hubertp Awaiting requested review from hubertp hubertp is a code owner

Assignees

@JaroslavTulach JaroslavTulach

Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Polyglot classes ignored in the type check signature
3 participants
@JaroslavTulach @radeusgd @Akirathan