Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opening projects with arbitrary name #8012

Conversation

4e6
Copy link
Contributor

@4e6 4e6 commented Oct 9, 2023

Pull Request Description

related #7973

Fixes opening the projects with names that are not in Upper_Snake_Case.

Important Notes

enso-7973.mp4

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.

@4e6 4e6 added the CI: No changelog needed Do not require a changelog entry for this PR. label Oct 9, 2023
@4e6 4e6 self-assigned this Oct 9, 2023
@somebody1234
Copy link
Contributor

this is a minor change, and basic testing indicates that it's working well, so merging.

i'm getting an unrelated error when trying to rename a project too quickly after closing it (?) though:

[INFO] [2023-10-10T11:09:13+10:00] [org.enso.projectmanager.infrastructure.languageserver.LanguageServerBootLoader] Language server booted [LanguageServerConnectionInfo(127.0.0.1,54915,60397)].
[INFO] [2023-10-10T11:09:13+10:00] [org.enso.projectmanager.infrastructure.languageserver.ProjectRenameAction] Requesting a Language Server to rename project [New_Project_18].
[ERROR] [2023-10-10T11:09:13+10:00] [org.enso.projectmanager.infrastructure.languageserver.ProjectRenameAction] Error occurred during renaming project [code: 6001, message: Session not initialised]
[ERROR] [2023-10-10T11:09:13+10:00] [org.enso.projectmanager.requesthandler.ProjectRenameHandler] Request Number(16) failed due to LanguageServerFailure(Failure during renaming [code: 6001 message: Session not initialised].).

@somebody1234 somebody1234 added the CI: Ready to merge This PR is eligible for automatic merge label Oct 10, 2023
@mergify mergify bot merged commit 11997e9 into develop Oct 10, 2023
36 checks passed
@mergify mergify bot deleted the wip/db/7973-issues-with-non-camel-case-projects-when-serializing-modules branch October 10, 2023 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants