Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for Table.from_objects and Table.expand_column. #8010

Merged
merged 20 commits into from
Oct 11, 2023

Conversation

GregoryTravis
Copy link
Contributor

@GregoryTravis GregoryTravis commented Oct 9, 2023

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@GregoryTravis GregoryTravis marked this pull request as ready for review October 9, 2023 16:17
@GregoryTravis GregoryTravis added the CI: No changelog needed Do not require a changelog entry for this PR. label Oct 9, 2023
Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, tests look great!

IMO Database.Table.from_objects is not needed - it will just confuse users - we will have 2 entries in the Component Browser - one for in-memory that works and one for DB that does nothing useful.

We want to keep instance methods in sync for the APIs to be consistent, but static methods are another story - there is no need to align them and it can even be harmful (as here, adding a duplicate entry to CB). So I'd rather remove this stub.

GregoryTravis and others added 4 commits October 10, 2023 11:39
Co-authored-by: Radosław Waśko <radoslaw.wasko@enso.org>
Co-authored-by: Radosław Waśko <radoslaw.wasko@enso.org>
@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Oct 11, 2023
@mergify mergify bot merged commit a2c8940 into develop Oct 11, 2023
35 checks passed
@mergify mergify bot deleted the wip/gmt/7958-from-objects-tests branch October 11, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants