-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for Table.from_objects and Table.expand_column. #8010
Conversation
test/Table_Tests/src/Common_Table_Operations/Conversion_Spec.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Database/0.0.0-dev/src/Extensions/Table_Conversions.enso
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, tests look great!
IMO Database.Table.from_objects
is not needed - it will just confuse users - we will have 2 entries in the Component Browser - one for in-memory that works and one for DB that does nothing useful.
We want to keep instance methods in sync for the APIs to be consistent, but static methods are another story - there is no need to align them and it can even be harmful (as here, adding a duplicate entry to CB). So I'd rather remove this stub.
Co-authored-by: Radosław Waśko <radoslaw.wasko@enso.org>
Co-authored-by: Radosław Waśko <radoslaw.wasko@enso.org>
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.