Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue writing to a dry run Excel File #7763

Merged
merged 4 commits into from
Sep 8, 2023
Merged

Conversation

jdunkerley
Copy link
Member

@jdunkerley jdunkerley commented Sep 7, 2023

Pull Request Description

  • Adds size to File.
  • If file is empty, then create a new Excel file.
  • Fixes dry run Excel write issue.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@jdunkerley jdunkerley added the CI: No changelog needed Do not require a changelog entry for this PR. label Sep 7, 2023
Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test for the directory case.

If we decide to remove the or total size of a folder., then either way it would be good to see a 'negative' test for what happens if size is called on a folder.

@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Sep 7, 2023
@mergify mergify bot merged commit f0ae9bf into develop Sep 8, 2023
27 checks passed
@mergify mergify bot deleted the wip/jd/fix-excel-write branch September 8, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants