-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes issue writing to a dry run Excel File #7763
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdunkerley
requested review from
radeusgd,
GregoryTravis,
4e6,
JaroslavTulach,
hubertp and
Akirathan
as code owners
September 7, 2023 09:00
jdunkerley
added
the
CI: No changelog needed
Do not require a changelog entry for this PR.
label
Sep 7, 2023
radeusgd
reviewed
Sep 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test for the directory case.
If we decide to remove the or total size of a folder.
, then either way it would be good to see a 'negative' test for what happens if size
is called on a folder.
engine/runtime/src/main/java/org/enso/interpreter/runtime/data/EnsoFile.java
Outdated
Show resolved
Hide resolved
radeusgd
reviewed
Sep 7, 2023
distribution/lib/Standard/Table/0.0.0-dev/src/Internal/Excel_Writer.enso
Show resolved
Hide resolved
radeusgd
approved these changes
Sep 7, 2023
JaroslavTulach
approved these changes
Sep 7, 2023
GregoryTravis
approved these changes
Sep 7, 2023
hubertp
approved these changes
Sep 7, 2023
Fix issue with Excel writing to a dry run file.
Handle errors on size.
jdunkerley
force-pushed
the
wip/jd/fix-excel-write
branch
from
September 7, 2023 14:59
790b5ad
to
d86b2d5
Compare
Akirathan
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI: No changelog needed
Do not require a changelog entry for this PR.
CI: Ready to merge
This PR is eligible for automatic merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
size
toFile
.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.