Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speeding up RuntimeVisualizationsTest by one minute #10891

Merged

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Aug 24, 2024

Pull Request Description

The same test is executed twice and once it receives three responses and once only two. Modifying the test to expect just two.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Scala,
  • Unit tests run and some run faster by one minute

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Aug 24, 2024
@JaroslavTulach JaroslavTulach force-pushed the wip/jtulach/RuntimeVisualizationsTestFasterByOneMinute branch from f7e5428 to 9d94443 Compare August 24, 2024 08:10
@JaroslavTulach
Copy link
Member Author

I am surprise there is no check that the number of received events is correct. Thus I am adding:

attachVisualizationResponses.size should be(2)

with just that one line changed, one of the tests fails and second succeeds:

sbt:runtime-integration-tests> testOnly *RuntimeVisualizationsTest -- -z subexpression
[info] compiling 1 Scala source to /home/devel/NetBeansProjects/enso/enso.ide/engine/runtime-integration-tests/target/scala-2.13/test-classes ...
[info] RuntimeVisualizationsTest:
[info]   3 was not equal to 2 (RuntimeVisualizationsTest.scala:4169)
[info] - should emit visualization update for the target of a method call (subexpression) with IdMap (1 second, 741 milliseconds)
Tests: succeeded 1, failed 1, canceled 0, ignored 0, pending 0

e.g. the first test was really receiving just two messages. The second one was getting all three.

@JaroslavTulach JaroslavTulach merged commit e9d3f59 into develop Aug 24, 2024
41 checks passed
@JaroslavTulach JaroslavTulach deleted the wip/jtulach/RuntimeVisualizationsTestFasterByOneMinute branch August 24, 2024 09:18
@enso-bot
Copy link

enso-bot bot commented Aug 26, 2024

Jaroslav Tulach reports a new STANDUP for the last Saturday (2024-08-24):

Progress: - merged IO.print: #10858

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants