Experiment: Reporting test failures as annotations #10821
Draft
+72
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeusgd
added
the
CI: No changelog needed
…ns (and also make the output more readable...)
|
This is what the annotations look like on a PR. I think this could be a helpful improvement when looking for test failures - instead of having to dig into the workflows, we can display them right there. They also appear in the workflow summary: |
| @@ -223,7 +223,9 @@ impl BuiltEnso { | |||
| if errors.is_empty() { | |||
| Ok(()) | |||
| } else { | |||
| error!("{} test suit(s) failed.", errors.len()); | |||
| let summary = errors.as_slice().iter().map(|e| e.to_string()).collect::<Vec<_>>().join(", "); | |||
| println!("::error title=Failed Standard Library Tests::{} test suite(s) failed: {}", errors.len(), summary); | |||
There was a problem hiding this comment.
I see a line starting with :: - that must be a GitHub Actions command line! Where is the syntax documented?
There was a problem hiding this comment.
I am glad we ended up doing the same - e.g. using println! to print the command line without a prefix. Just like at my PR.
|
I did not manage to cleanup and finish this yet because I was focusing on more pressing tasks. I will re-visit this once I'm back from vacation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.