Make all Common_Spec tests pass for SQLSerever #10810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdRiley
force-pushed
the
wip/adr/more-sql-server-tests
branch
from
7336d90
to
013e4a6
Compare
AdRiley
force-pushed
the
wip/adr/more-sql-server-tests
branch
from
3d6615a
to
77545ab
Compare
AdRiley
added
the
CI: No changelog needed
AdRiley
changed the title
AdRiley
requested review from
jdunkerley,
radeusgd,
GregoryTravis and
marthasharkey
as code owners
GregoryTravis
approved these changes
Sep 10, 2024
jdunkerley
approved these changes
Sep 10, 2024
distribution/lib/Standard/Microsoft/0.0.0-dev/src/Internal/SQLServer_Dialect.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Microsoft/0.0.0-dev/src/Internal/SQLServer_Dialect.enso
Show resolved
Hide resolved
jdunkerley
pushed a commit
that referenced
this pull request
Sep 13, 2024
* More SQL tests * Remove duplicate * Fix another test * Temp fix * More temporay fixes * More green * Another green * Another one * Fix counts * Temporary change * Fix tests * Auto-commit work in progress before clean build on 2024-09-06 10:53:46 * Another fix * Green * Specialise ensure_query_has_no_holes * cleanup * Cleanup * Cleanup * Clean * Code review changes (cherry picked from commit b8516f7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Makes all tests in Common_Spec.enso pass for SQLServer. This doesn't cover full functionality just that set of tests.
Will refactor the database tests before proceeding further.
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.