Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc editor and code editor are toggleable docks #10413

Merged
merged 4 commits into from
Jul 4, 2024
Merged

Conversation

kazcw
Copy link
Contributor

@kazcw kazcw commented Jul 1, 2024

Pull Request Description

Dock improvements:

  • Right and bottom docks are toggled with buttons.
  • Bottom dock:
    • Fills available width.
    • Height resize handle behaves like right dock's.
  • Documentation editor: Top toolbar is outside scrollable area.
  • Extended menu: Entries have icons.
  • Add component button: Now in bottom-right.
Screen.Recording.2024-07-01.at.09.37.07.mov

Closes #10385, #10386.

Important Notes

  • unrefElement: Fixed a type-safety bug in; documented a reactivity limitation.
  • keyboardBusy: Fixed a bug where shortcuts were ignored after clicking any button.
  • Fixed right-dock slide-in animation.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@kazcw kazcw added the CI: No changelog needed Do not require a changelog entry for this PR. label Jul 1, 2024
@kazcw kazcw self-assigned this Jul 1, 2024
@kazcw kazcw force-pushed the wip/kw/docks branch 2 times, most recently from b1f62e3 to d31320a Compare July 1, 2024 16:32
@kazcw kazcw marked this pull request as ready for review July 1, 2024 16:39
// Target size is passed via CSS variable --slide-in-panel-size.
const props = defineProps<{
show: boolean
// Default: from right.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just saw we have a SizeTransition component already, so we don't need this.

@kazcw kazcw added the CI: Ready to merge This PR is eligible for automatic merge label Jul 4, 2024
@kazcw kazcw linked an issue Jul 4, 2024 that may be closed by this pull request
@mergify mergify bot merged commit d46e4ac into develop Jul 4, 2024
37 checks passed
@mergify mergify bot deleted the wip/kw/docks branch July 4, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Code Editor Panel Open/Close button Add Documentation Panel Open/Close button
2 participants