Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node Edit mode and accepting CB edits. #7786

Closed
Tracked by #7685
farmaazon opened this issue Sep 11, 2023 · 14 comments · Fixed by #8183
Closed
Tracked by #7685

Node Edit mode and accepting CB edits. #7786

farmaazon opened this issue Sep 11, 2023 · 14 comments · Fixed by #8183
Assignees
Labels
-gui d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints

Comments

@farmaazon
Copy link
Contributor

farmaazon commented Sep 11, 2023

When a node is being edited, the component browser should be displayed in its place, with its input content being a node expression. The text cursor should be in the proper place (where the user clicked).

If CB is closed in other way than aborting edit (with ESC), The input should be saved as new node's expression. The node (and thus the code) should not be updated before.

Optionally, there could be an animation of node being extended to CB input.

@farmaazon farmaazon mentioned this issue Sep 11, 2023
@farmaazon farmaazon added d-intermediate Difficulty: some prior knowledge required p-high Should be completed in the next sprint -gui labels Sep 11, 2023
@farmaazon farmaazon added p-medium Should be completed in the next few sprints and removed p-high Should be completed in the next sprint labels Sep 21, 2023
@enso-bot
Copy link

enso-bot bot commented Oct 13, 2023

Michael Mauderer reports a new STANDUP for today (2023-10-13):

Progress: Started working on node edit mode. It should be finished by 2023-10-19.

Next Day: Next day I will be working on the #7786 task. Start next task.

@enso-bot
Copy link

enso-bot bot commented Oct 17, 2023

Michael Mauderer reports a new STANDUP for yesterday (2023-10-16):

Progress: Continued work on node edit mode, setting up scaffolding for input node replacement. It should be finished by 2023-10-19.

Next Day: Next day I will be working on the #7786 task. Continue work on task.

@enso-bot
Copy link

enso-bot bot commented Oct 18, 2023

Michael Mauderer reports a new STANDUP for yesterday (2023-10-17):

Progress: Continued work on node edit mode, hooking up input events and syncing node and CB states. It should be finished by 2023-10-19.

Next Day: Next day I will be working on the #7786 task. Continue work on task.

@enso-bot
Copy link

enso-bot bot commented Oct 19, 2023

Michael Mauderer reports a new STANDUP for yesterday (2023-10-18):

Progress: Continued worked on transferring edit and text states between edited node abs component browser input field. It should be finished by 2023-10-19.

Next Day: Next day I will be working on the #7786 task. Continue work on task.

@enso-bot
Copy link

enso-bot bot commented Oct 20, 2023

Michael Mauderer reports a new 🔴 DELAY for yesterday (2023-10-19):

Summary: There is 4 days delay in implementation of the Node Edit mode and accepting CB edits. (#7786) task.
It will cause 0 days delay for the delivery of this weekly plan.

Implementation and debugging of outstanding issues taking longer than anticipated.

Delay Cause: 2 days weekend,2 day delay.

@enso-bot
Copy link

enso-bot bot commented Oct 20, 2023

Michael Mauderer reports a new STANDUP for yesterday (2023-10-19):

Progress: Worked on finishing overall open CB on Edit -> Editing -> Apply edit to node pipeline. Some bugs related to focus management and open/closing CB left to solve. It should be finished by 2023-10-23.

Next Day: Next day I will be working on the #7786 task. Continue work on task.

@enso-bot
Copy link

enso-bot bot commented Oct 23, 2023

Michael Mauderer reports a new STANDUP for the provided date (2023-10-20):

Progress: Fixed the bugs related to focus management and visibility. Working on fixing bugs related to positioning while zoomed and correct code generation. It should be finished by 2023-10-23.

Next Day: Next day I will be working on the #7786 task. Fix remaining bugs.

@enso-bot
Copy link

enso-bot bot commented Oct 24, 2023

Michael Mauderer reports a new STANDUP for yesterday (2023-10-23):

Progress: Fixed remaining issues around focus and clarified state of code generation in CB with Adam. It should be finished by 2023-10-23.

Next Day: Next day I will be working on the #7786 task. Open PR and start next task.

@enso-bot
Copy link

enso-bot bot commented Oct 25, 2023

Michael Mauderer reports a new 🔴 DELAY for yesterday (2023-10-24):

Summary: There is 2 days delay in implementation of the Node Edit mode and accepting CB edits. (#7786) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: Issues with develop on my machine that are blocking me from testing the code and confirming correct behaviour.

@enso-bot
Copy link

enso-bot bot commented Oct 25, 2023

Michael Mauderer reports a new STANDUP for yesterday (2023-10-24):

Progress: Investigating irregular issues around component browser vanishing and not creating nodes (on develop on my machine), in order to be able to test and finish this task. It should be finished by 2023-10-25.

Next Day: Next day I will be working on the #7786 task. Open PR and start next task.

@enso-bot
Copy link

enso-bot bot commented Oct 26, 2023

Michael Mauderer reports a new STANDUP for yesterday (2023-10-25):

Progress: Fixed remaining issues. Rebased to develop and fixed resulting merge issues. It should be finished by 2023-10-25.

Next Day: Next day I will be working on the #7786 task. Open PR and start next task.

@enso-bot
Copy link

enso-bot bot commented Oct 27, 2023

Michael Mauderer reports a new 🔴 DELAY for yesterday (2023-10-26):

Summary: There is 2 days delay in implementation of the Node Edit mode and accepting CB edits. (#7786) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: Fixing merge conflicts and regressions on develop.

@enso-bot
Copy link

enso-bot bot commented Oct 27, 2023

Michael Mauderer reports a new STANDUP for yesterday (2023-10-26):

Progress: Worked on fixing regressions on develop that prevented the CB from creating new nodes, which in turn affects the functionality of the current work in progress. It should be finished by 2023-10-27.

Next Day: Next day I will be working on the #7786 task. Open PR and start next task.

@enso-bot
Copy link

enso-bot bot commented Oct 30, 2023

Michael Mauderer reports a new STANDUP for the provided date (2023-10-27):

Progress: Finished updating and fixing remaining bugs. It should be finished by 2023-10-27.

Next Day: Next day I will be working on the #8015 task. Open PR and start next task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants