Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed write (issue #112) #113

Closed
wants to merge 3 commits into from
Closed

fixed write (issue #112) #113

wants to merge 3 commits into from

Conversation

domenukk
Copy link
Member

This PR replaces Telnetlib's write function with a direct call to sock.sendall, see #112.

@domenukk domenukk mentioned this pull request May 18, 2021
Closed
@domenukk domenukk mentioned this pull request May 18, 2021
Closed
@domenukk
Copy link
Member Author

This may not be exhaustive. 0xFF can also be an issue on read (and lead to unwanted blocks).
TL;DR: Non-textual msgs should not be transmitted using Telnetlib :(

@domenukk domenukk closed this May 20, 2021
@sinitax sinitax mentioned this pull request May 20, 2021
Merged
@Trolldemorted
Copy link
Member

Textual messages can also make trouble - some UTF BOMs contain 0xff.

@ldruschk
Copy link
Member

Textual messages can also make trouble - some UTF BOMs contain 0xff.

not in UTF-8 at least

@Trolldemorted
Copy link
Member

Sure, but UTF-16 is where insane ctf services are at! 😛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@domenukk @Trolldemorted @ldruschk