Remove serve_once and deamon-specific options from utils.py
#102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So, the |
ldruschk
approved these changes
Apr 24, 2021
|
I am not sure how essential we deem the removed test case, so we might want to recreate those using a different server, but we could probably do that after the PR is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, utils.py has some fancy features nobody ended up using.
Especially,
serve_onceshould be removed - it opens a webpage that can be used be exactly once.I don't think we have checkers that use it, and as far as servers go, we moved to flask a long time ago.
enochecker/src/enochecker/utils.py
Line 197 in 30e0024
On top,
deamonizecan be dropped, as it's no longer hard to do on python3 (and should be avoided in checkers at all cost)