Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong parent can be selected in multi-inheritance sync #10343 #10344

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

vbradnitski
Copy link
Contributor

No description provided.

@vbradnitski vbradnitski linked an issue Nov 29, 2023 that may be closed by this pull request
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (e020e42) 84.48% compared to head (8635c2e) 84.48%.

❗ Current head 8635c2e differs from pull request most recent head 1dfd864. Consider uploading reports for the commit 1dfd864 to get more accurate results

Files Patch % Lines
...nonic/xp/core/impl/project/ProjectServiceImpl.java 40.00% 1 Missing and 2 partials ⚠️
...core/impl/content/ProjectContentEventListener.java 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             issue-10242   #10344      +/-   ##
=================================================
- Coverage          84.48%   84.48%   -0.01%     
- Complexity         19473    19474       +1     
=================================================
  Files               2598     2598              
  Lines              67776    67779       +3     
  Branches            5384     5384              
=================================================
  Hits               57261    57261              
  Misses              7910     7910              
- Partials            2605     2608       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vbradnitski vbradnitski merged commit bf6a085 into issue-10242 Nov 29, 2023
2 of 3 checks passed
@vbradnitski vbradnitski deleted the issue-10343 branch November 29, 2023 11:53
alansemenov pushed a commit that referenced this pull request Dec 19, 2023
* Multi-inheritance in layers #10242

* NPE on project create after multi-inheritance implementation #10338

* Wrong parent can be selected in multi-inheritance sync #10343 (#10344)

* Wrong parent can be selected for sync during layer init #10346 (#10347)

* layers cycle when project gets created #10350 (#10355)

* Config to enable multilayer #10351 (#10359)

---------

Co-authored-by: rymsha <rymsha@yandex.ru>
alansemenov pushed a commit that referenced this pull request Dec 22, 2023
* Multi-inheritance in layers #10242

* NPE on project create after multi-inheritance implementation #10338

* Wrong parent can be selected in multi-inheritance sync #10343 (#10344)

* Wrong parent can be selected for sync during layer init #10346 (#10347)

* layers cycle when project gets created #10350 (#10355)

* Config to enable multilayer #10351 (#10359)

---------

Co-authored-by: rymsha <rymsha@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-inheritance in layers
2 participants