Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support GraalVM jlink #9483

Closed
rymsha opened this issue May 27, 2022 · 4 comments
Closed

Support GraalVM jlink #9483

rymsha opened this issue May 27, 2022 · 4 comments
Assignees
@rymsha
Labels
Improvement
Milestone
7.10.0

Comments

@rymsha
Copy link
Contributor

rymsha commented May 27, 2022 •
edited
Loading

Due to https://bugs.openjdk.java.net/browse/JDK-8237467 not yet fixed jlinked GraalVM need -XX:+UnlockExperimentalVMOptions -XX:+UseJVMCICompiler
@rymsha rymsha self-assigned this May 27, 2022
@rymsha
Copy link
Contributor Author

rymsha commented May 27, 2022

Note https://openjdk.java.net/jeps/410 removes JVMCI from from OpenJDK 17 and UseJVMCICompiler will probably produce an error. But since we are going to run only on GraalVM it should not matter.

@rymsha rymsha added this to the 7.10.0 milestone May 27, 2022
rymsha added a commit that referenced this issue May 27, 2022
@rymsha
Support GraalVM jlink #9483
18e2545
rymsha added a commit that referenced this issue May 27, 2022
@rymsha
Support GraalVM jlink #9483
6cd87d1
rymsha added a commit that referenced this issue May 30, 2022
@rymsha
Support GraalVM jlink #9483
67ec1ce
@rymsha
Copy link
Contributor Author

rymsha commented May 30, 2022

After EnableJVMCIProduct during jlink is applied all we don't need manual UseJVMCICompiler option

@rymsha
Copy link
Contributor Author

rymsha commented Jun 8, 2022

jlink --add-options does not work well on Windows. Restored EnableJVMCIProduct in server.bat for now

rymsha added a commit that referenced this issue Jun 8, 2022
@rymsha
Support GraalVM jlink #9483
e14054a
rymsha added a commit that referenced this issue Jun 15, 2022
@rymsha
Support GraalVM jlink #9483
f245e39 
- still allow to run on stock OpenJDK on Windows
- if custom Nashorn engine is used, don't swallow deprecation warning
@rymsha
Copy link
Contributor Author

rymsha commented Jun 15, 2022

From now on if NashornScriptEngine is used directly by any app, warning will be shown in logs. This is done to warn application developers that it is time to switch to new Engine.

Internal XP ScriptEngine manually disables this warning.

anatol-sialitski pushed a commit that referenced this issue Jun 29, 2022
@rymsha @anatol-sialitski
Support GraalVM jlink #9483
7bd83b9
anatol-sialitski pushed a commit that referenced this issue Jun 29, 2022
@rymsha @anatol-sialitski
Support GraalVM jlink #9483
51e00be
anatol-sialitski pushed a commit that referenced this issue Jun 29, 2022
@rymsha @anatol-sialitski
Support GraalVM jlink #9483
1055326
anatol-sialitski pushed a commit that referenced this issue Jun 29, 2022
@rymsha @anatol-sialitski
Support GraalVM jlink #9483
676d490 
- still allow to run on stock OpenJDK on Windows
- if custom Nashorn engine is used, don't swallow deprecation warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rymsha rymsha

Labels
Improvement
Projects
None yet
Milestone
7.10.0
Development

No branches or pull requests
2 participants
@rymsha @alansemenov