Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify state for duplicated content #8829

Closed
alansemenov opened this issue May 18, 2021 · 4 comments
Closed

Allow to specify state for duplicated content #8829

alansemenov opened this issue May 18, 2021 · 4 comments
Assignees
Milestone

Comments

@alansemenov
Copy link
Member

@Sneiwert commented on Tue Sep 17 2019

When copying an event it shows "ready to publish", but nothing has been edited or approved.


@Sneiwert commented on Tue Sep 17 2019

Screenshot 2019-09-17 at 13 04 49


@alansemenov commented on Fri Sep 20 2019

@Sneiwert It's not obvious to me that this is wrong behaviour. When you duplicate a content that is "ready", the duplicate is also "ready". When you start changing the duplicate - which is what you most likely duplicated it for - then it will change to "In progress". Makes total sense to me.

Let's discuss this.


@Sneiwert commented on Fri Sep 20 2019

I see what you mean. But when the duplicate has an old event date from the past, it should automatically detect that this content has to be modified before being published. The copied content should be validated before it is showing "Ready".


@Sneiwert commented on Fri Sep 20 2019

I talked to @sigdestad about this, he knows the issue.


@alansemenov commented on Thu May 13 2021

Should most likely be fixed in admin API.


@ashklianko commented on Sat May 15 2021

@alansemenov we only send ids to duplicate, result is fully created on backend, so I believe it is a backend task

@sigdestad
Copy link
Member

I'm thinking abou this. It makes sense from a user perspective - but we must discuss this more closely before we start any implementation on this task.

@rymsha rymsha added the To Be Discussed Issues that require additional discussion label May 25, 2021
@rymsha
Copy link
Contributor

rymsha commented Sep 12, 2022

We tried to forcibly change Workflow State in XP, but it causes issues. #9520 #9663
Bets solution would be to allow specifying State in DuplicateContentParams

@rymsha rymsha removed the To Be Discussed Issues that require additional discussion label Oct 13, 2022
@rymsha
Copy link
Contributor

rymsha commented Oct 13, 2022

There are two issues:

  1. workflow state is copied in duplicate (so ready state is copied, too)
  2. to be able to specify workflow state DuplicateContentParams should have State param

we cannot "just" remove workflow state because default value is "ready"

@rymsha rymsha changed the title Duplicated content should always be created in state "In Progress" Allow to specify state for duplicated content Oct 13, 2022
@rymsha rymsha added this to the 7.12.0 milestone Oct 13, 2022
@rymsha
Copy link
Contributor

rymsha commented Oct 13, 2022

New implementation allows to specify WorkflowInfo just like content.create does
It is up to CS to set IN_PROGRESS.
By default nothing is changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants