Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ItemStatisticsHeader.createIconEl: check if param has optional getIconSrc function #2592

Closed
ashklianko opened this issue May 24, 2022 · 0 comments
Closed

ItemStatisticsHeader.createIconEl: check if param has optional getIconSrc function #2592

ashklianko opened this issue May 24, 2022 · 0 comments
Assignees
@ashklianko
Labels
Bug Something isn't working Not in Changelog Quick fixes

Comments

@ashklianko
Copy link
Member

Recent changes break statistics panels when ViewItem doesn't have optional getIconSrc function
@ashklianko ashklianko added the Bug Something isn't working label May 24, 2022
@ashklianko ashklianko self-assigned this May 24, 2022
ashklianko added a commit that referenced this issue May 24, 2022
@ashklianko
ItemStatisticsHeader.createIconEl: check if param has optional getIco…
4a7c846 
…nSrc function #2592
@ashklianko ashklianko mentioned this issue May 24, 2022
Merged
alansemenov added a commit that referenced this issue May 24, 2022
@alansemenov
Check existence of getIconSrc via typeof (#2592)
30ac11d
alansemenov pushed a commit that referenced this issue May 24, 2022
@ashklianko @alansemenov
ItemStatisticsHeader.createIconEl: check if param has optional getIco…
d7ffcda 
…nSrc function #2592
alansemenov added a commit that referenced this issue May 24, 2022
@alansemenov
Check existence of getIconSrc via typeof (#2592)
2224495
@alansemenov alansemenov added the Not in Changelog Quick fixes label May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashklianko ashklianko

Labels
Bug Something isn't working Not in Changelog Quick fixes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ashklianko @alansemenov