This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
Override Docker ENTRYPOINT so that PID 1 inside the container is correctly assigned #571
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pm2-runtime
will now run as PID 1 as intended in #533. See also enketo/enketo#960.I have verified this PR works with
(…because no application code has changed. If anyone feels they're warranted, however, I'm happy to carry out the tests.)
What else has been done to verify that this works as intended?
Verified
pm2-runtime
as PID 1 within the container using the following method:Why is this the best possible solution? Were any other approaches considered?
The
CMD
instruction could've been modified instead of switching toENTRYPOINT
, but even if that did work, it would rely on a convoluted execution path that depends on some peculiar behavior of thenode:14
base image.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Systems administrators should notice that Enketo Docker containers exit cleanly and more quickly. I can't foresee any negative consequences. The change should have no impact on end users.
Do we need any specific form for testing your changes? If so, please attach one.
No.