This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
Fix: works around issue with canvas not printing in puppeteer's PDF g… #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eneration, closes #512
MartijnR
commented
Jan 11, 2023
| * (though not WebGL-related as some of the commenters suggest) | ||
| */ | ||
| await page.evaluate(() => { | ||
| /* eslint-env browser */ |
There was a problem hiding this comment.
It's unclear what the scope of this eslint-env override is. Setting it to eslint-env: node after this page.evaluate function doesn't actually seem to switch it back.
eyelidlessness
approved these changes
Feb 1, 2023
|
thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eneration, closes enketo/enketo#969
I have verified this PR works with
What else has been done to verify that this works as intended?
The code is only used for PDF generation. Therefore, I've only tested the PDF API endpoints.
Why is this the best possible solution? Were any other approaches considered?
I concluded that the issue is a bug in puppeteer in the printToPDF implementation of a '2d' canvas. Therefore, it seemed best to work around it. In the PDF view, there is no need for a real canvas, so converting canvases to images seemed an acceptable solution.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Regression risks are styling changes in the drawing widget or general images that unintentionally affect drawings in the PDF view.
Do we need any specific form for testing your changes?
See the linked issue for API calls to reproduce the issue and test the fix.