Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLA-1906] fix wallet texts #142

Merged
merged 2 commits into from
Jul 29, 2024
Merged

[PLA-1906] fix wallet texts #142

merged 2 commits into from
Jul 29, 2024

Conversation

zlayine
Copy link
Contributor

@zlayine zlayine commented Jul 29, 2024 •
edited by github-actions bot
Loading

PR Type

Bug fix

Description

  • Fixed the conditional rendering logic in SettingsWalletAccount.vue by changing v-else-if to v-if for displaying connected wallets.

Changes walkthrough 📝

Relevant files
Bug fix
SettingsWalletAccount.vue
Fix conditional rendering for connected wallets display   

resources/js/components/pages/SettingsWalletAccount.vue

  • Changed v-else-if directive to v-if for displaying connected wallets.
    		•  +1/-1     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @zlayine zlayine requested a review from enjinabner July 29, 2024 13:57
    @zlayine zlayine self-assigned this Jul 29, 2024
    @github-actions GitHub Actions
    Copy link

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No key issues to review

    @github-actions GitHub Actions
    Copy link

    github-actions bot commented Jul 29, 2024 •
    edited
    Loading

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @zlayine zlayine merged commit fd2f575 into master Jul 29, 2024
    3 checks passed
    @zlayine zlayine deleted the hotfix/pla-1906/wallet-account branch July 29, 2024 14:09
    leonardocustodio pushed a commit that referenced this pull request Aug 5, 2024
    @zlayine @leonardocustodio
    [PLA-1906] fix wallet texts (#142)
    33732c7
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @enjinabner enjinabner enjinabner approved these changes

    Assignees

    @zlayine zlayine

    Labels
    Bug fix Review effort [1-5]: 1
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    2 participants
    @zlayine @enjinabner