[PLA-1781] update password query

[zlayine]

PR Type

Bug fix, Enhancement

---

Description

• Removed reCAPTCHA functionality from VerifyPasswordModal.vue.
• Updated the confirm method in VerifyPasswordModal.vue to call AuthApi.updateUser instead of AuthApi.login.
• Simplified the modal confirmation process in VerifyPasswordModal.vue.
• Fixed the logic in index.ts to limit the total count of collection IDs fetched to a maximum of 500.

---

Changes walkthrough 📝

	Relevant files
Enhancement	VerifyPasswordModal.vue Remove reCAPTCHA and update password confirmation logic.  resources/js/components/pages/VerifyPasswordModal.vue Removed reCAPTCHA functionality. Updated confirm method to call AuthApi.updateUser instead of AuthApi.login. Simplified modal confirmation process. +3/-53
Bug fix	index.ts Fix collection IDs fetching logic.                                              resources/js/store/index.ts Fixed logic to limit the total count of collection IDs fetched to a maximum of 500. +1/-1

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[github-actions]

PR Description updated to latest commit (72d745e)

[github-actions]

PR Review 🔍

⏱️ Estimated effort to review [1-5]	2, because the changes are localized to specific components and methods, and the logic is straightforward. The removal of reCAPTCHA and the update in API call are significant but not complex.
🧪 Relevant tests	No
⚡ Possible issues	Possible Bug: The removal of reCAPTCHA without alternative security measures might reduce the security level of the password verification process.
🔒 Security concerns	No

Code feedback:

---

relevant file	resources/js/components/pages/VerifyPasswordModal.vue
suggestion	Consider implementing alternative security measures to compensate for the removal of reCAPTCHA, such as rate limiting or additional verification steps. This will help maintain the security integrity of the password verification process. [important]
relevant line	-

---

relevant file	resources/js/store/index.ts
suggestion	Refactor the conditional logic for limiting collection IDs to use a constant for the maximum allowed value (500). This improves code readability and maintainability. [medium]
relevant line	await this.fetchCollectionIds(collectionsData.totalCount > 500 ? 500 : collectionsData.totalCount);

---

[github-actions]

PR Code Suggestions ✨

Category	Suggestion	Score
Security	Reinforce security by reintroducing captcha or similar mechanisms Consider re-adding some form of captcha or security measure to prevent brute force attacks, especially since the original implementation included a captcha mechanism. resources/js/components/pages/VerifyPasswordModal.vue [25] -<Btn primary @click="confirm">Confirm</Btn> +<Btn primary @click="verifyAndConfirm">Confirm</Btn> Suggestion importance[1-10]: 9 Why: The original implementation included a captcha mechanism for security, which was removed in the PR. Reintroducing a captcha or similar security measure is crucial for preventing brute force attacks, making this a high-priority suggestion.	9
Enhancement	Improve robustness by handling errors in network requests Replace the direct call to AuthApi.updateUser with a method that handles errors and possibly re-authenticates or retries the request. This is important for improving the robustness of the network request handling. resources/js/components/pages/VerifyPasswordModal.vue [50] -const res = await AuthApi.updateUser(email, password.value); +const res = await safeUpdateUser(email, password.value); Suggestion importance[1-10]: 8 Why: This suggestion improves the robustness of the network request handling by introducing a method that can handle errors and possibly re-authenticate or retry the request. This is a significant improvement for error handling and overall application stability.	8
Possible issue	Add error handling for user update failures Add error handling for the updateUser API call to manage cases where the update fails, such as displaying a user-friendly error message. resources/js/components/pages/VerifyPasswordModal.vue [50] -const res = await AuthApi.updateUser(email, password.value); +try { + const res = await AuthApi.updateUser(email, password.value); + if (!res.data.Login) throw new Error('Update failed'); +} catch (error) { + snackbar.show('Error updating user: ' + error.message); +} Suggestion importance[1-10]: 8 Why: Adding error handling for the updateUser API call is essential for managing cases where the update fails. Displaying a user-friendly error message improves the user experience and helps in debugging issues.	8
Performance	Prevent excessive server load by capping the number of collection IDs fetched Consider adding a check to ensure that the totalCount does not exceed a certain threshold to prevent excessive server load or potential denial of service if the count is unexpectedly high. resources/js/store/index.ts [190] -await this.fetchCollectionIds(collectionsData.totalCount > 500 ? 500 : collectionsData.totalCount); +const maxCount = 500; +const safeCount = Math.min(collectionsData.totalCount, maxCount); +await this.fetchCollectionIds(safeCount); Suggestion importance[1-10]: 7 Why: This suggestion adds a check to ensure that the totalCount does not exceed a certain threshold, which helps prevent excessive server load or potential denial of service. This is a good practice for performance optimization and server stability.	7